secstate/Iris
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Use RFC 4648 s.5 URL-safe Base64 for URL encoding

Browse Source 
Switch to RFC 4648 Base 64 Encoding with URL and Filename Safe Alphabet.
https://en.wikipedia.org/wiki/Base64#Variants_summary_table
https://datatracker.ietf.org/doc/html/rfc4648#section-5

Before this change certain Mopidy backend URIs when encoded contained
forward slashes. The forward slashes prevented those URIs from being
loaded.
This commit is contained in:
Davis Mosenkovs
2025-03-12 23:52:24 +02:00
parent 30c90a4734
commit e86a021b8e
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/js/util/format.js
View File

@ -317,7 +317,7 @@ const formatSimpleObjects = function (records = []) {
*/
const encodeUri = (rawUri = '') => {
try {
return btoa(unescape(encodeURIComponent(rawUri)));
return btoa(unescape(encodeURIComponent(rawUri))).replaceAll('+', '-').replaceAll('/', '_');
} catch {
console.error('Failed to encode', rawUri);
return null;
@ -329,6 +329,7 @@ const encodeUri = (rawUri = '') => {
*
* Why base64? Some Mopidy backends have varying encoding styles, and handling all of these became
* unweildy. Instead we take whatever Mopidy gives us, convert to binary, and then base64 it.
* We use RFC 4648 Base 64 Encoding with URL and Filename Safe Alphabet.
*
* Even when a URI is not URIEncoded, the browser will do some of it's own encoding/decoding which
* we can avoid by giving a base64 string.
@ -336,7 +337,7 @@ const encodeUri = (rawUri = '') => {
*/
const decodeUri = (rawUri = '') => {
try {
return decodeURIComponent(escape(atob(rawUri)));
return decodeURIComponent(escape(atob(rawUri.replaceAll('-', '+').replaceAll('_', '/'))));
} catch {
console.error('Failed to decode', rawUri);
return null;