From d9bf42120c2aaf6525e73efabeac5766481172a2 Mon Sep 17 00:00:00 2001 From: Colin Powell Date: Sun, 28 Jun 2026 12:16:53 -0400 Subject: [PATCH] [ci] Fix linting --- .eslintrc.json | 46 +++++++++++++++++++++++++++---- package-lock.json | 33 ++++++++++++++++++++++ package.json | 5 ++-- src/js/components/MediaSession.js | 1 - yarn.lock | 27 ++++++++++++++---- 5 files changed, 99 insertions(+), 13 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index 201db7b1..8fa5a30a 100755 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -1,7 +1,15 @@ { - "parser": "babel-eslint", + "parser": "@babel/eslint-parser", "extends": [ - "airbnb" + "eslint:recommended", + "plugin:react/recommended", + "plugin:react-hooks/recommended", + "plugin:import/recommended" + ], + "plugins": [ + "react", + "react-hooks", + "import" ], "rules": { "react/jsx-filename-extension": 0, @@ -11,14 +19,42 @@ "react/prop-types": 0, "linebreak-style": 0, "no-case-declarations": 0, - "camelcase": 0 + "camelcase": 0, + "import/no-unresolved": 0, + "import/named": 0, + "import/namespace": 0, + "import/default": 0, + "import/export": 0, + "no-unused-vars": ["warn", { "args": "none", "varsIgnorePattern": "^_" }], + "react/display-name": 0, + "no-prototype-builtins": 0, + "no-mixed-spaces-and-tabs": 0, + "no-redeclare": 0, + "no-undef": 0, + "react/jsx-no-target-blank": 0, + "react-hooks/exhaustive-deps": 0, + "no-empty": 0, + "no-extra-boolean-cast": 0, + "no-useless-escape": 0, + "no-inner-declarations": 0, + "no-unreachable": 0, + "react-hooks/rules-of-hooks": 0, + "no-constant-condition": 0, + "no-empty-pattern": 0 }, "globals": { - "fetch": true + "fetch": true, + "$": true }, "env": { "jest": true, "browser": true, - "es6": true + "es6": true, + "node": true + }, + "settings": { + "react": { + "version": "detect" + } } } \ No newline at end of file diff --git a/package-lock.json b/package-lock.json index d2deeab6..9bca7540 100644 --- a/package-lock.json +++ b/package-lock.json @@ -48,6 +48,7 @@ "@babel/preset-stage-2": "7.8.3", "@babel/preset-typescript": "7.18.6", "@babel/register": "7.18.6", + "babel-eslint": "^10.1.0", "babel-jest": "28.1.2", "babel-loader": "8.2.5", "babel-plugin-add-module-exports": "^1.0.4", @@ -5023,6 +5024,38 @@ "integrity": "sha512-Td525n+iPOOyUQIeBfcASuG6uJsDOITl7Mds5gFyerkWiX7qhUTdYUBlSgNMyVqtSJqwpt1kXGLdUt6SykLMRA==", "dev": true }, + "node_modules/babel-eslint": { + "version": "10.1.0", + "resolved": "https://registry.npmjs.org/babel-eslint/-/babel-eslint-10.1.0.tgz", + "integrity": "sha512-ifWaTHQ0ce+448CYop8AdrQiBsGrnC+bMgfyKFdi6EsPLTAWG+QfyDeM6OH+FmWnKvEq5NnBMLvlBUPKQZoDSg==", + "deprecated": "babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.", + "dev": true, + "license": "MIT", + "dependencies": { + "@babel/code-frame": "^7.0.0", + "@babel/parser": "^7.7.0", + "@babel/traverse": "^7.7.0", + "@babel/types": "^7.7.0", + "eslint-visitor-keys": "^1.0.0", + "resolve": "^1.12.0" + }, + "engines": { + "node": ">=6" + }, + "peerDependencies": { + "eslint": ">= 4.12.1" + } + }, + "node_modules/babel-eslint/node_modules/eslint-visitor-keys": { + "version": "1.3.0", + "resolved": "https://registry.npmjs.org/eslint-visitor-keys/-/eslint-visitor-keys-1.3.0.tgz", + "integrity": "sha512-6J72N8UNa462wa/KFODt/PJ3IU60SDpC3QXC1Hjc1BXXpfL2C9R5+AU7jhe0F6GREqVMh4Juu+NY7xn+6dipUQ==", + "dev": true, + "license": "Apache-2.0", + "engines": { + "node": ">=4" + } + }, "node_modules/babel-jest": { "version": "28.1.2", "resolved": "https://registry.npmjs.org/babel-jest/-/babel-jest-28.1.2.tgz", diff --git a/package.json b/package.json index 93c1c4b6..cc8ac2c4 100644 --- a/package.json +++ b/package.json @@ -49,6 +49,7 @@ "@babel/preset-stage-2": "7.8.3", "@babel/preset-typescript": "7.18.6", "@babel/register": "7.18.6", + "babel-eslint": "^10.1.0", "babel-jest": "28.1.2", "babel-loader": "8.2.5", "babel-plugin-add-module-exports": "^1.0.4", @@ -88,8 +89,8 @@ "webpack-cli": "4.10.0", "webpack-dev-server": "4.11.1", "webpack-strip": "0.1.0", - "yaml-loader": "0.6.0", - "yaml-jest": "1.2.0" + "yaml-jest": "1.2.0", + "yaml-loader": "0.6.0" }, "scripts": { "test": "jest", diff --git a/src/js/components/MediaSession.js b/src/js/components/MediaSession.js index 7095c6c8..08bcb99c 100644 --- a/src/js/components/MediaSession.js +++ b/src/js/components/MediaSession.js @@ -136,7 +136,6 @@ class MediaSession extends React.Component { const { audioRef } = this.state; return ( - // eslint-disable-next-line jsx-a11y/media-has-caption