secstate/Iris
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Reducing opportunities for undefined variables; Origin-stamping errors

Browse Source
This commit is contained in:
James Barnsley
2017-09-25 20:22:48 +13:00
parent 60a560f4b3
commit beafc9e2a8
5 changed files with 101 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
src/js/services/spotify/actions.js
View File

@ -56,8 +56,9 @@ const sendRequest = ( dispatch, getState, endpoint, method = 'GET', data = false
(xhr, status, error) => {
dispatch(uiActions.stopLoading(loader_key))
dispatch(coreActions.handleException(
xhr.responseJSON.error.message,
'Spotify: '+xhr.responseJSON.error.message,
{
source: 'spotify/actions.js/sendRequest',
config: config,
xhr: xhr,
status: status,
@ -99,10 +100,6 @@ function getToken( dispatch, getState ){
.then(
response => {
resolve(response.access_token)
},
error => {
dispatch({ type: 'SPOTIFY_DISCONNECTED' })
reject(error)
}
);
});
@ -134,8 +131,9 @@ function refreshToken( dispatch, getState ){
(xhr, status, error) => {
dispatch({ type: 'SPOTIFY_DISCONNECTED' })
dispatch(coreActions.handleException(
xhr.responseJSON.error_description,
'Spotify: '+xhr.responseJSON.error_description,
{
source: 'spotify/actions.js/refreshToken',
config: config,
xhr: xhr,
status: status,
@ -146,7 +144,7 @@ function refreshToken( dispatch, getState ){
}
);
}else{
} else {
$.ajax({
method: 'GET',
@ -158,8 +156,16 @@ function refreshToken( dispatch, getState ){
response => {
if (response.type == 'error'){
dispatch({ type: 'SPOTIFY_DISCONNECTED' })
dispatch(uiActions.createNotification(response.message,'bad'))
console.error('Could not refresh token', response)
dispatch(coreActions.handleException(
'Spotify: '+response.message,
{
source: 'spotify/actions.js/refreshToken',
config: config,
xhr: xhr,
status: status,
error: error
}
))
reject(response)
} else {
@ -177,8 +183,16 @@ function refreshToken( dispatch, getState ){
},
error => {
dispatch({ type: 'SPOTIFY_DISCONNECTED' })
dispatch(uiActions.createNotification('Could not refresh token','bad'))
console.error('Could not refresh token', error)
dispatch(coreActions.handleException(
'Spotify: Could not refresh token',
{
source: 'spotify/actions.js/refreshToken',
config: config,
xhr: xhr,
status: status,
error: error
}
))
reject(error)
}
);