From 63d23a7d54ff3d0b487931f9188471cbe1d303a5 Mon Sep 17 00:00:00 2001 From: James Barnsley Date: Fri, 27 Apr 2018 12:54:02 +1200 Subject: [PATCH 1/2] Fixing added_by placeholder and search as _from --- src/js/components/Track.js | 6 +++++- src/js/views/Search.js | 4 ++-- src/scss/components/_lists.scss | 3 ++- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/js/components/Track.js b/src/js/components/Track.js index 7f0ec0b6..9ec62781 100755 --- a/src/js/components/Track.js +++ b/src/js/components/Track.js @@ -228,6 +228,10 @@ export default class Track extends React.Component{ var link = browse break; + case "search": + var link = search + break; + default: var link = {type}; } @@ -238,7 +242,7 @@ export default class Track extends React.Component{ var added = track.added_by } else { - var added = - + var added = - } track_columns.push( diff --git a/src/js/views/Search.js b/src/js/views/Search.js index d7236200..df9d57cc 100755 --- a/src/js/views/Search.js +++ b/src/js/views/Search.js @@ -218,7 +218,7 @@ class Search extends React.Component{ Tracks
- + this.loadMore('tracks') }/>
@@ -285,7 +285,7 @@ class Search extends React.Component{ if (tracks.length > 0){ var tracks_section = (
- + this.loadMore('tracks') }/>
) diff --git a/src/scss/components/_lists.scss b/src/scss/components/_lists.scss index 4d327967..d8031620 100755 --- a/src/scss/components/_lists.scss +++ b/src/scss/components/_lists.scss @@ -353,7 +353,8 @@ float: none !important; padding-left: 0.25em; - .by { + .by, + .empty { display: none; } From aa5f80c2015d90749fa7f4da0f820aff55ce7b34 Mon Sep 17 00:00:00 2001 From: James Barnsley Date: Fri, 27 Apr 2018 16:36:48 +1200 Subject: [PATCH 2/2] Comments --- src/js/services/mopidy/middleware.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/js/services/mopidy/middleware.js b/src/js/services/mopidy/middleware.js index 83aec6e7..b3e5bf91 100755 --- a/src/js/services/mopidy/middleware.js +++ b/src/js/services/mopidy/middleware.js @@ -93,6 +93,7 @@ const MopidyMiddleware = (function(){ break; case 'event:trackPlaybackEnded': + // This doesn't fire when it's the last track in the queue... bug in Mopidy? store.dispatch(mopidyActions.clearCurrentTrack()); store.dispatch(mopidyActions.getTimePosition()); break;