From 5ac3c6254aecfd84d7dbfd6ca0a37aee35b82498 Mon Sep 17 00:00:00 2001
From: James Barnsley <james@barnsley.nz>
Date: Sat, 1 Apr 2023 17:54:35 +1300
Subject: [PATCH] Using built-in link underline - Setting decoration-thickness
 for nicer control of appearance

---
 src/scss/components/_sub-tabs.scss  |  4 ++--
 src/scss/components/_sub-views.scss | 22 +---------------------
 src/scss/global/_core.scss          | 13 +++++--------
 src/scss/global/_forms.scss         |  4 ++++
 src/scss/views/_artist.scss         |  2 +-
 5 files changed, 13 insertions(+), 32 deletions(-)

diff --git a/src/scss/components/_sub-tabs.scss b/src/scss/components/_sub-tabs.scss
index 29d35282..0ee8d748 100755
--- a/src/scss/components/_sub-tabs.scss
+++ b/src/scss/components/_sub-tabs.scss
@@ -17,8 +17,6 @@
 			padding: 0 5px;
 			display: block;
 			box-sizing: border-box;
-			border: none !important;
-			text-decoration: none !important;
 			cursor: pointer;
 
 			&__inner {
@@ -61,6 +59,8 @@
 			}
 
 			&:hover {
+				text-decoration: none;
+
 				.menu-item__inner {
 					background: lighten(colour('dark_grey'), 4%);
 
diff --git a/src/scss/components/_sub-views.scss b/src/scss/components/_sub-views.scss
index eb463cca..2ac088a3 100755
--- a/src/scss/components/_sub-views.scss
+++ b/src/scss/components/_sub-views.scss
@@ -7,8 +7,6 @@
     margin-right: 25px;
     font-size: 15px;
     font-weight: 500;
-    border-bottom: 0;
-    padding-bottom: 3px;
     cursor: pointer;
 
     @include theme('light') {
@@ -21,25 +19,7 @@
 
     &--active,
     &:hover {
-      border-bottom-width: 3px !important;
-      border-bottom-style: solid;
-      padding-bottom: 0px;
-    }
-
-    &--active {
-      border-color: colour('white') !important;
-
-      @include theme('light') {
-        border-color: colour('darkest_grey') !important;
-      }
-    }
-
-    &:not(.sub-views__option--active):hover {
-      border-color: colour('soft_grey') !important;
-
-      @include theme('light') {
-        border-color: colour('light_grey') !important;
-      }
+      text-decoration: underline 0.15em;
     }
   }
 
diff --git a/src/scss/global/_core.scss b/src/scss/global/_core.scss
index 95fe15cb..03d478c8 100755
--- a/src/scss/global/_core.scss
+++ b/src/scss/global/_core.scss
@@ -194,10 +194,8 @@ main {
     text-decoration: none;
     cursor: pointer;
 
-    &:not(.control):not(.action):not(.button) {
-      &:hover {
-        text-decoration: underline;
-      }
+    &:hover {
+      text-decoration: underline 0.15em;
     }
   }
 
@@ -260,17 +258,16 @@ h2 {
 
   a {
     color: inherit;
-    text-decoration: none;
+    text-decoration: none 2px;
 
     &:hover {
-      border-bottom: 2px solid colour('white');
+      text-decoration: underline 2px;
     }
   }
 
   &.grey-text {
     a:hover {
       color: colour('mid_grey') !important;
-      border-bottom: 2px solid colour('mid_grey');
     }
   }
 }
@@ -340,7 +337,7 @@ h5 {
     text-decoration: none;
 
     &:hover {
-      text-decoration: underline;
+      text-decoration: underline 0.15em;
     }
   }
 }
diff --git a/src/scss/global/_forms.scss b/src/scss/global/_forms.scss
index 1d01b908..cd688562 100755
--- a/src/scss/global/_forms.scss
+++ b/src/scss/global/_forms.scss
@@ -214,6 +214,10 @@ select {
     transform: translate(1px, 1px);
   }
 
+  &:hover {
+    text-decoration: none;
+  }
+
   @include theme('light') {
     &--default {
       border-color: colour('darkest_grey');
diff --git a/src/scss/views/_artist.scss b/src/scss/views/_artist.scss
index 97878906..d771199e 100755
--- a/src/scss/views/_artist.scss
+++ b/src/scss/views/_artist.scss
@@ -66,7 +66,7 @@
 
         .biography-text {
           overflow-wrap: break-word;
-	  white-space: pre-wrap;
+          white-space: pre-wrap;
         }
       }
     }