From 597f6918070a13fedda4879659d9dddecac1018c Mon Sep 17 00:00:00 2001 From: James Barnsley Date: Sat, 29 Jan 2022 07:48:53 +1300 Subject: [PATCH] Disable dragability fully unless can_sort, prevents impossible scrolling on touch devices --- src/js/components/Track.js | 36 +++++++++++++++++++----------------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/src/js/components/Track.js b/src/js/components/Track.js index 3d09e57e..2579ad59 100755 --- a/src/js/components/Track.js +++ b/src/js/components/Track.js @@ -120,23 +120,25 @@ const Track = ({ // If we're touchable, and can sort this tracklist let drag_zone = null; let wrapperRef = useRef(null); - if (isTouchDevice() && can_sort) { - // Drag ref is our handler ONLY - // Drop ref is our whole row, so the whole row can be dropped on - wrapperRef = drop(wrapperRef); - className += ' list__item--has-drag-zone'; - drag_zone = ( - events.onTouchStart(item, index, e)} - ref={drag} - > - - - ); - } else { - // Merge drag and drop refs - wrapperRef = drag(drop(wrapperRef)); + if (can_sort) { + if (isTouchDevice()) { + // Drag ref is our handler ONLY + // Drop ref is our whole row, so the whole row can be dropped on + wrapperRef = drop(wrapperRef); + className += ' list__item--has-drag-zone'; + drag_zone = ( + events.onTouchStart(item, index, e)} + ref={drag} + > + + + ); + } else { + // Merge drag and drop refs + wrapperRef = drag(drop(wrapperRef)); + } } const track_middle_column = ;