diff --git a/src/js/views/Artist.js b/src/js/views/Artist.js index ebbe0c9e..ab777971 100755 --- a/src/js/views/Artist.js +++ b/src/js/views/Artist.js @@ -40,7 +40,8 @@ class Artist extends React.Component { super(props); this.state = { - filter: '', + albumsFilter: '', + tracksFilter: '', }; } @@ -76,23 +77,33 @@ class Artist extends React.Component { if (prevUri !== uri && artist) this.setWindowTitle(artist); } - onResetFilters = () => { - this.onChangeFilter(null); - this.onChangeSort(null); - trackEvent({ category: 'Artist', action: 'FilterAlbums', label: 'Reset' }); + onChangeTracksFilter = (value) => { + this.onChangeFilter('tracks', value); } - onChangeFilter = (value) => { + onChangeAlbumsFilter = (value) => { + this.onChangeFilter('albums', value); + } + + onChangeFilter = (type, value) => { const { uiActions: { set, hideContextMenu } } = this.props; - set({ artist_albums_filter: value }); + set({ [`artist_${type}_filter`]: value }); hideContextMenu(); - trackEvent({ category: 'Artist', action: 'FilterAlbums', label: value }); + trackEvent({ category: 'Artist', action: `Filter${type}`, label: value }); } - onChangeSort = (value) => { + onChangeTracksSort = (value) => { + this.onChangeSort('tracks', value); + } + + onChangeAlbumsSort = (value) => { + this.onChangeSort('albums', value); + } + + onChangeSort = (type, value) => { const { - sort, - sort_reverse, + [`${type}_sort`]: sort, + [`${type}_sort_reverse`]: sort_reverse, uiActions: { set, hideContextMenu, @@ -105,11 +116,11 @@ class Artist extends React.Component { } set({ - artist_albums_sort_reverse: reverse, - artist_albums_sort: value, + [`artist_${type}_sort_reverse`]: reverse, + [`artist_${type}_sort`]: value, }); hideContextMenu(); - trackEvent({ category: 'Artist', action: 'SortAlbums', label: `${value} ${reverse ? 'DESC' : 'ASC'}` }); + trackEvent({ category: 'Artist', action: `Sort${type}`, label: `${value} ${reverse ? 'DESC' : 'ASC'}` }); } onPlay = () => { @@ -163,12 +174,12 @@ class Artist extends React.Component { uri, uiActions, artist, - sort, - sort_reverse, - filterType + albums_sort: sort, + albums_sort_reverse: sort_reverse, + filterType, } = this.props; const { - filter, + albumsFilter: filter, } = this.state; let { tracks, @@ -259,7 +270,7 @@ class Artist extends React.Component {