From 2906e782c75ddd3e395a3ce8425cc216d685a36f Mon Sep 17 00:00:00 2001 From: James Barnsley Date: Mon, 16 Jan 2017 21:49:04 +1300 Subject: [PATCH] Adding to playlists... seems buggy --- src/js/components/ContextMenu.js | 6 ++++-- src/js/components/Modal/AddToPlaylistModal.js | 6 ++++-- src/js/helpers.js | 2 +- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/js/components/ContextMenu.js b/src/js/components/ContextMenu.js index e491630e..1aa59037 100755 --- a/src/js/components/ContextMenu.js +++ b/src/js/components/ContextMenu.js @@ -107,10 +107,12 @@ class ContextMenu extends React.Component{ renderPlaylistSubmenu(){ var playlists = [] - for( var i = 0; i < this.props.playlists.length; i++ ){ - if( this.props.playlists[i].can_edit ) playlists.push( this.props.playlists[i] ) + for (var uri in this.props.playlists){ + if (this.props.playlists[uri].can_edit) playlists.push( this.props.playlists[uri]) } + playlists = helpers.sortItems(playlists, 'name') + return (
{ diff --git a/src/js/components/Modal/AddToPlaylistModal.js b/src/js/components/Modal/AddToPlaylistModal.js index 3b95e25e..dc14db52 100755 --- a/src/js/components/Modal/AddToPlaylistModal.js +++ b/src/js/components/Modal/AddToPlaylistModal.js @@ -18,10 +18,12 @@ export default class AddToPlaylistModal extends React.Component{ render(){ if( !this.props.playlists ) return
No editable playlists
var playlists = [] - for( var i = 0; i < this.props.playlists.length; i++ ){ - if( this.props.playlists[i].can_edit ) playlists.push( this.props.playlists[i] ) + for (var uri in this.props.playlists){ + if( this.props.playlists[uri].can_edit ) playlists.push( this.props.playlists[uri] ) } + playlists = helpers.sortItems(playlists, 'name') + return (

Add to playlist

diff --git a/src/js/helpers.js b/src/js/helpers.js index 3cbe09fa..41d653fd 100755 --- a/src/js/helpers.js +++ b/src/js/helpers.js @@ -351,7 +351,7 @@ export let sortItems = function (array, property, reverse = false){ } } - var sorted = array.sort(compare) + var sorted = Object.assign([], array.sort(compare)) if( reverse ) sorted.reverse() return sorted }