Improving library lists display

This commit is contained in:
James Barnsley
2020-12-18 21:54:50 +13:00
parent bacbe59b14
commit 06036eec21
12 changed files with 40 additions and 30 deletions

View File

@ -4271,7 +4271,8 @@ select {
margin-left: auto;
z-index: 9;
flex: 4;
justify-content: flex-end; }
justify-content: flex-end;
order: 2; }
.list__item__column--right .list__item__column__item {
padding-left: 10px;
display: inline-block; }

File diff suppressed because one or more lines are too long

View File

@ -106430,6 +106430,7 @@ var List = /*#__PURE__*/function (_React$Component) {
link_prefix = _this$props.link_prefix,
thumbnail = _this$props.thumbnail,
details = _this$props.details,
right_column = _this$props.right_column,
nocontext = _this$props.nocontext;
if (!rows) return null;
return /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_0___default.a.createElement("div", {
@ -106449,6 +106450,7 @@ var List = /*#__PURE__*/function (_React$Component) {
},
thumbnail: thumbnail,
details: details,
right_column: right_column,
nocontext: nocontext,
"data-qa-node": "ListItem",
"data-qa-file": "List"
@ -106615,12 +106617,11 @@ var ListItem = /*#__PURE__*/function (_React$Component) {
item = _objectWithoutProperties(_this$props$item, [key].map(_toPropertyKey));
if (key === 'tracks') {
var total = item.tracks_total,
array = item.tracks;
if (!total && !array) return null;
var total = item.tracks_total;
if (!total && !value) return null;
return /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_0___default.a.createElement(_locale__WEBPACK_IMPORTED_MODULE_9__["I18n"], {
path: "specs.tracks",
count: total || array.length,
count: total || value.length,
"data-qa-node": "I18n",
"data-qa-file": "ListItem"
});
@ -106628,11 +106629,16 @@ var ListItem = /*#__PURE__*/function (_React$Component) {
if (key === 'artists') {
var _total = item.artists_total,
_array = item.artists_uris;
if (!_total && !_array) return null;
array = item.artists_uris;
if (Array.isArray(value)) return /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_0___default.a.createElement(_LinksSentence__WEBPACK_IMPORTED_MODULE_1__["default"], {
items: value,
"data-qa-node": "LinksSentence",
"data-qa-file": "ListItem"
});
if (!_total && !array) return null;
return /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_0___default.a.createElement(_locale__WEBPACK_IMPORTED_MODULE_9__["I18n"], {
path: "specs.artists",
count: _total || _array.length,
count: _total || array.length,
"data-qa-node": "I18n",
"data-qa-file": "ListItem"
});
@ -106640,11 +106646,11 @@ var ListItem = /*#__PURE__*/function (_React$Component) {
if (key === 'albums') {
var _total2 = item.albums_total,
_array2 = item.albums_uris;
if (!_total2 && !_array2) return null;
_array = item.albums_uris;
if (!_total2 && !_array) return null;
return /*#__PURE__*/react__WEBPACK_IMPORTED_MODULE_0___default.a.createElement(_locale__WEBPACK_IMPORTED_MODULE_9__["I18n"], {
path: "specs.albums",
count: _total2 || _array2.length,
count: _total2 || _array.length,
"data-qa-node": "I18n",
"data-qa-file": "ListItem"
});
@ -138937,8 +138943,8 @@ var LibraryAlbums = /*#__PURE__*/function (_React$Component) {
handleContextMenu: _this.handleContextMenu,
rows: albums,
thumbnail: true,
details: ['artists', 'tracks', 'added_at'],
right_column: ['added_at'],
details: ['artists'],
right_column: ['added_at', 'tracks'],
className: "albums",
link_prefix: "/album/",
"data-qa-node": "List",
@ -139435,8 +139441,8 @@ var LibraryArtists = /*#__PURE__*/function (_React$Component) {
},
rows: artists,
thumbnail: true,
details: ['albums', 'followers'],
middle_column: ['source'],
details: ['followers', 'popularity'],
right_column: ['source', 'albums'],
className: "artists",
link_prefix: "/artist/",
"data-qa-node": "List",

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

View File

@ -106,7 +106,7 @@
// Release details
// These are automatically injected to built HTML
var build = "1608106910";
var build = "1608281618";
var version = "3.55.4";
// Construct the script tag

View File

@ -27,6 +27,7 @@ class List extends React.Component {
link_prefix,
thumbnail,
details,
right_column,
nocontext,
} = this.props;
@ -46,6 +47,7 @@ class List extends React.Component {
handleContextMenu={(e) => this.handleContextMenu(e, item)}
thumbnail={thumbnail}
details={details}
right_column={right_column}
nocontext={nocontext}
/>
))

View File

@ -100,16 +100,16 @@ export default class ListItem extends React.Component {
if (key === 'tracks') {
const {
tracks_total: total,
tracks: array,
} = item;
if (!total && !array) return null;
return <I18n path="specs.tracks" count={total || array.length} />;
if (!total && !value) return null;
return <I18n path="specs.tracks" count={total || value.length} />;
}
if (key === 'artists') {
const {
artists_total: total,
artists_uris: array,
} = item;
if (Array.isArray(value)) return <LinksSentence items={value} />;
if (!total && !array) return null;
return <I18n path="specs.artists" count={total || array.length} />;
}

View File

@ -218,8 +218,8 @@ class LibraryAlbums extends React.Component {
handleContextMenu={this.handleContextMenu}
rows={albums}
thumbnail
details={['artists', 'tracks', 'added_at']}
right_column={['added_at']}
details={['artists']}
right_column={['added_at', 'tracks']}
className="albums"
link_prefix="/album/"
/>

View File

@ -196,8 +196,8 @@ class LibraryArtists extends React.Component {
handleContextMenu={(e, item) => this.handleContextMenu(e, item)}
rows={artists}
thumbnail
details={['albums', 'followers']}
middle_column={['source']}
details={['followers', 'popularity']}
right_column={['source', 'albums']}
className="artists"
link_prefix="/artist/"
/>

View File

@ -193,6 +193,7 @@
z-index: 9;
flex: 4;
justify-content: flex-end;
order: 2;
.list__item__column__item {
padding-left: 10px;